[
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810591#comment-17810591
]
ASF GitHub Bot commented on HBASE-28327:
----------------------------------------
Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909063763
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 10s | master passed |
| +1 :green_heart: | compile | 0m 25s | master passed |
| +1 :green_heart: | checkstyle | 0m 12s | master passed |
| +1 :green_heart: | spotless | 0m 44s | branch has no errors when
running spotless:check. |
| +1 :green_heart: | spotbugs | 0m 32s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | the patch passed |
| +1 :green_heart: | compile | 0m 24s | the patch passed |
| +1 :green_heart: | javac | 0m 24s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 12s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | hadoopcheck | 5m 33s | Patch does not cause any
errors with Hadoop 3.3.6. |
| +1 :green_heart: | spotless | 0m 42s | patch has no errors when
running spotless:check. |
| +1 :green_heart: | spotbugs | 0m 46s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate
ASF License warnings. |
| | | 23m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/5647 |
| Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti
spotless checkstyle compile |
| uname | Linux b646b7786b2e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 354a3a2774 |
| Default Java | Eclipse Adoptium-11.0.17+8 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-metrics-api hbase-metrics U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console
|
| versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Add remove(String key, Metric metric) method to MetricRegistry interface
> ------------------------------------------------------------------------
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
> Issue Type: Improvement
> Reporter: Evelyn Boland
> Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry`
> interface. Right now the interface only contains a `remove(String name)`
> method.
> This additional remove method will give users the power to remove a `Metric`
> with the specified `name` from the metric registry if and only if the
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight
> forward because the `MetricRegistryImpl` class stores metrics in a
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)`
> method
> This change will not be a breaking one because the interface is marked with
> `@IntefaceStability.Evolving`
> [~rmdmattingly]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
