[
https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810593#comment-17810593
]
ASF GitHub Bot commented on HBASE-28327:
----------------------------------------
Apache-HBase commented on PR #5647:
URL: https://github.com/apache/hbase/pull/5647#issuecomment-1909072401
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 58s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list
--whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 36s | master passed |
| +1 :green_heart: | compile | 0m 31s | master passed |
| +1 :green_heart: | shadedjars | 7m 22s | branch has no errors when
building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 54s | the patch passed |
| +1 :green_heart: | compile | 0m 33s | the patch passed |
| +1 :green_heart: | javac | 0m 33s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 14s | patch has no errors when
building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 19s | hbase-metrics-api in the patch
passed. |
| +1 :green_heart: | unit | 0m 22s | hbase-metrics in the patch passed.
|
| | | 27m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/5647 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4b9b9175c0d4 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23
14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 354a3a2774 |
| Default Java | Temurin-1.8.0_352-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
|
| Max. process+thread count | 168 (vs. ulimit of 30000) |
| modules | C: hbase-metrics-api hbase-metrics U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console
|
| versions | git=2.34.1 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Add remove(String key, Metric metric) method to MetricRegistry interface
> ------------------------------------------------------------------------
>
> Key: HBASE-28327
> URL: https://issues.apache.org/jira/browse/HBASE-28327
> Project: HBase
> Issue Type: Improvement
> Reporter: Evelyn Boland
> Priority: Major
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry`
> interface. Right now the interface only contains a `remove(String name)`
> method.
> This additional remove method will give users the power to remove a `Metric`
> with the specified `name` from the metric registry if and only if the
> provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight
> forward because the `MetricRegistryImpl` class stores metrics in a
> `ConcurrentMap`, which already contains a `remove(Object key, Object value)`
> method
> This change will not be a breaking one because the interface is marked with
> `@IntefaceStability.Evolving`
> [~rmdmattingly]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
