bbeaudreault commented on code in PR #5654:
URL: https://github.com/apache/hbase/pull/5654#discussion_r1476495524
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -690,6 +690,7 @@ private Result increment(final HRegion region, final
OperationQuota quota,
if (metricsRegionServer != null) {
long blockBytesScanned =
context != null ? context.getBlockBytesScanned() -
blockBytesScannedBefore : 0;
+ quota.addBlockBytesScanned(blockBytesScanned);
Review Comment:
this may not be a huge issue, but i think this shouldn't be within the
metricsRegionServer != null check. Maybe move this and the above line up outside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
