bbeaudreault commented on code in PR #5654:
URL: https://github.com/apache/hbase/pull/5654#discussion_r1476610558
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -2841,6 +2845,9 @@ public MultiResponse multi(final RpcController rpcc,
final MultiRequest request)
spaceQuotaEnforcement);
}
} finally {
+ if (context != null) {
Review Comment:
I dont think this works out so well, because of how some of the methods are
abstracted. For example, `increment` can be called from the single `mutate`
method and also from `doNonAtomicRegionMutation` (which is called from
`multi`). So for increments, we'd double account them.
I might recommend only adding calls to addBlockBytesScanned wherever there
are existing calls to getBlockBytesScanned() for metrics. As I mentioned in
another comment, you'll want to move the getBlockBytesScanned() outside the if
(metrics != null) checks, but otherwise those are probably the best places to
add the quota calls if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
