Apache9 commented on code in PR #5631:
URL: https://github.com/apache/hbase/pull/5631#discussion_r1477005895
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##########
@@ -303,12 +309,16 @@ protected void initChannel(Channel ch) throws Exception {
.addListener(new ChannelFutureListener() {
private void succeed(Channel ch) throws IOException {
- ch.writeAndFlush(connectionHeaderPreamble.retainedDuplicate());
+ if (connectionRegistryCall != null) {
+ getConnectionRegistry(ch);
+ return;
+ }
+ NettyFutureUtils.safeWriteAndFlush(ch,
connectionHeaderPreamble.retainedDuplicate());
if (useSasl) {
saslNegotiate(ch);
} else {
// send the connection header to server
- ch.write(connectionHeaderWithLength.retainedDuplicate());
+ NettyFutureUtils.safeWrite(ch,
connectionHeaderWithLength.retainedDuplicate());
Review Comment:
Just some error prone warning on 'future return value ignored', not critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
