Apache9 commented on code in PR #5631:
URL: https://github.com/apache/hbase/pull/5631#discussion_r1477006153
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java:
##########
@@ -688,41 +691,75 @@ private void doBadPreambleHandling(String msg) throws
IOException {
}
private void doBadPreambleHandling(String msg, Exception e) throws
IOException {
- RpcServer.LOG.warn(msg);
+ RpcServer.LOG.warn(msg, e);
doRespond(getErrorResponse(msg, e));
}
+ private boolean doConnectionRegistryResponse() throws IOException {
+ if (!(rpcServer.server instanceof ConnectionRegistryEndpoint)) {
+ // should be in tests or some scenarios where we should not reach here
+ return false;
+ }
+ // on backup masters, this request may be blocked since we need to fetch
it from filesystem,
+ // but since it is just backup master, it is not a critical problem
+ String clusterId = ((ConnectionRegistryEndpoint)
rpcServer.server).getClusterId();
Review Comment:
The request is blocked, not the backup masters are blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
