NihalJain commented on code in PR #5607:
URL: https://github.com/apache/hbase/pull/5607#discussion_r1489390006
##########
hbase-assembly/src/main/assembly/hadoop-three-compat.xml:
##########
@@ -115,6 +115,13 @@
<exclude>junit:junit</exclude>
<exclude>org.hamcrest:hamcrest-core</exclude>
<exclude>org.mockito:mockito-core</exclude>
+ <!-- Exclude transitive dependencies of tomcat-jasper, not
needed at runtime -->
Review Comment:
Yes @Apache9, these are required at compile time to generate the jsp pages
but i was able to load web pages w/o them during runtime. Hence excluding from
assembly.
Few others which were not needed at all, I have already excluded in
dependencies section for the dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
