NihalJain commented on code in PR #5607:
URL: https://github.com/apache/hbase/pull/5607#discussion_r1506311515
##########
pom.xml:
##########
@@ -1531,21 +1530,30 @@
</dependency>
<dependency>
<!--This lib has JspC in it. Needed precompiling jsps in hbase-rest,
etc.-->
- <groupId>org.glassfish.web</groupId>
- <artifactId>javax.servlet.jsp</artifactId>
- <version>${glassfish.jsp.version}</version>
+ <groupId>org.apache.tomcat</groupId>
Review Comment:
I tried this change, but it does not work and fails in runtime with
following:
```
2024-02-28T22:42:08,437 INFO [qtp1543105131-146]
ContextHandler.regionserver: No JSP support. Check that JSP jars are in
lib/jsp and that the JSP option has been specified to start.jar
2024-02-28T22:42:13,554 WARN [qtp1643646293-343] server.HttpChannel:
/tablesDetailed.jsp
java.lang.NullPointerException: null
at
org.apache.hadoop.hbase.generated.master.tablesDetailed_jsp._jspService(tablesDetailed_jsp.java:175)
~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
~[tomcat-embed-jasper-8.5.99.jar:8.5.99]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:583)
~[tomcat-embed-core-8.5.99.jar:8.5.99]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:117)
~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hadoop.hbase.http.SecurityHeadersFilter.doFilter(SecurityHeadersFilter.java:65)
~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:49)
~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1595)
~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:60)
~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.handle(Server.java:516)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
~[hbase-shaded-jetty-4.1.5.jar:?]
at
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
~[hbase-shaded-jetty-4.1.5.jar:?]
at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_381]
```
Will need to figure out what all to add in classpath apart from
tomcat-embed-jasper. IMO using tomcat-jasper is a better idea as we are adding
just one jar and other required dependencies come transitively with
tomcat-jasper where we keep only transitive dependencies which we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
