bbeaudreault commented on code in PR #5686:
URL: https://github.com/apache/hbase/pull/5686#discussion_r1492640874


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java:
##########
@@ -390,7 +390,7 @@ protected static UserQuotaState 
buildDefaultUserQuotaState(Configuration conf) {
     buildDefaultTimedQuota(conf, QUOTA_DEFAULT_USER_MACHINE_WRITE_SIZE)
       .ifPresent(throttleBuilder::setWriteSize);
 
-    UserQuotaState state = new UserQuotaState();
+    UserQuotaState state = new 
UserQuotaState(EnvironmentEdgeManager.currentTime());

Review Comment:
   I think we need to add nowTs as an argument to this method. During initial 
creation of the quota (for a new user), you'd pass 0. During refresh, you'd 
pass the nowTs that exists within the fetchUserQuotas method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to