bbeaudreault commented on code in PR #5686:
URL: https://github.com/apache/hbase/pull/5686#discussion_r1492641713
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java:
##########
@@ -390,7 +390,7 @@ protected static UserQuotaState
buildDefaultUserQuotaState(Configuration conf) {
buildDefaultTimedQuota(conf, QUOTA_DEFAULT_USER_MACHINE_WRITE_SIZE)
.ifPresent(throttleBuilder::setWriteSize);
- UserQuotaState state = new UserQuotaState();
+ UserQuotaState state = new
UserQuotaState(EnvironmentEdgeManager.currentTime());
Review Comment:
The problem with always using currentTime() here is that when we add a new
user to the quota map, we trigger an immediate refresh. The idea is that the 0
value woudl cause the new user to be refreshed. But if you set it to now, it
wouldn't be refreshed until the next refresh interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
