NihalJain commented on code in PR #5695:
URL: https://github.com/apache/hbase/pull/5695#discussion_r1499115256
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##########
@@ -1203,12 +1203,6 @@ public void
preDecommissionRegionServers(ObserverContext<MasterCoprocessorEnviro
requirePermission(ctx, "decommissionRegionServers", Action.ADMIN);
}
- @Override
Review Comment:
IMO we should not drop the method. If we want to allow every user to be able
to be able to do so, we should have a no-op method and capture same as
comments.
Although I am curious why only this change when we have other methods around
listing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]