NihalJain commented on code in PR #5695:
URL: https://github.com/apache/hbase/pull/5695#discussion_r1503858370
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java:
##########
@@ -1203,12 +1203,6 @@ public void
preDecommissionRegionServers(ObserverContext<MasterCoprocessorEnviro
requirePermission(ctx, "decommissionRegionServers", Action.ADMIN);
}
- @Override
Review Comment:
> However I am curious to know the difference between removing this method
vs having a no-op method?
IMO removing a method may send a false impression to a future auditor that
there is no Access Rule defined for the method or it is somehow missing. And
the person may end up re-adding the method. So it's better to have it, even if
no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
