Apache9 commented on code in PR #5736:
URL: https://github.com/apache/hbase/pull/5736#discussion_r1508803103
##########
dev-support/create-release/release-util.sh:
##########
@@ -613,6 +613,8 @@ function update_releasenotes {
else
mv "${releasenotes}" "${project_dir}/RELEASENOTES.md"
fi
+ log "${MVN[@]}" spotless:apply -DspotlessFiles='RELEASENOTES*.md,CHANGES*.md'
Review Comment:
Is this the correct place to add this? For 3.x, we do not have CHANGES.md
and RELEASENOTES.md in our code base.
##########
dev-support/create-release/release-util.sh:
##########
@@ -745,6 +747,8 @@ function maven_set_version { #input: <version_to_set>
log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
"${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false | grep -v "no value" #
silence logs
fi
+ log "${MVN[@]}" spotless:apply -DspotlessFiles='**/pom.xml'
Review Comment:
How could setting version in pom break the style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
