ndimiduk commented on code in PR #5736:
URL: https://github.com/apache/hbase/pull/5736#discussion_r1508805407
##########
dev-support/create-release/release-util.sh:
##########
@@ -745,6 +747,8 @@ function maven_set_version { #input: <version_to_set>
log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
"${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false | grep -v "no value" #
silence logs
fi
+ log "${MVN[@]}" spotless:apply -DspotlessFiles='**/pom.xml'
Review Comment:
In theory it shouldn't. But then neither would generating release notes.
Since we manage the structure of these files via spotless, i figure better safe
than sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
