Apache9 commented on PR #5740: URL: https://github.com/apache/hbase/pull/5740#issuecomment-1978366652
> I think you can improve the test further by getting rid of shared state in the base class. But more/better coverage looks good. Do the additional permutations result in a longer test time? Does the MediumTest annotation need tweaked as well? The tests runs pretty fast, as it does not need to setup a mini cluster, just start some socket servers. On my local machine, the TestNettyIPC can be finished within 15 seconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
