Apache9 commented on code in PR #5740:
URL: https://github.com/apache/hbase/pull/5740#discussion_r1512542521


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java:
##########
@@ -114,14 +118,12 @@ public abstract class AbstractTestIPC {
   private static final KeyValue CELL = new KeyValue(CELL_BYTES, CELL_BYTES, 
CELL_BYTES, CELL_BYTES);
 
   protected static final Configuration CONF = HBaseConfiguration.create();

Review Comment:
   We can not get rid of it, we need to change some configurations in setUp and 
tearDown. And in TestNettyTlsIPC, we need to change the configurations in 
setUpBeforeClass, so it has to be static...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to