[
https://issues.apache.org/jira/browse/HBASE-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419834#comment-13419834
]
Zhihong Ted Yu commented on HBASE-6429:
---------------------------------------
Year is not needed in license header of FilterWrapper.java and
TestFilterWithScanLimits.java
{code}
+ // Wrap the following function calls
+ @Override
+ public void filterRow(List<KeyValue> kvs) {
{code}
Please change the above javadoc so that it explains the rationale behind this
JIRA.
{code}
+ if(scan.hasFilter()){
{code}
Space between if and (.
{code}
+ "Filter with filterRow(List<KeyValue>) or filterRow()
incompatible with scan with limit!");
{code}
Line length limit is 100 characters.
In the test:
{code}
+ } catch (IOException e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
{code}
I think we should fail the test above.
There're other TODO's in test code which needs handling.
Please run your next patch through unit tests before attaching.
Thanks
> Filter with filterRow() returning true is incompatible with scan with limit
> ---------------------------------------------------------------------------
>
> Key: HBASE-6429
> URL: https://issues.apache.org/jira/browse/HBASE-6429
> Project: HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.96.0
> Reporter: Jason Dai
> Attachments: hbase-6429-trunk.patch, hbase-6429_0_94_0.patch
>
>
> Currently if we scan with bot limit and a Filter with
> filterRow(List<KeyValue>) implemented, an IncompatibleFilterException will
> be thrown. The same exception should also be thrown if the filer has its
> filterRow() implemented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
