ndimiduk commented on code in PR #5775:
URL: https://github.com/apache/hbase/pull/5775#discussion_r1539165446
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##########
@@ -423,6 +424,54 @@ public String toString() {
+ (isReference() ? "->" + getReferredToFile(this.getPath()) + "-" +
reference : "");
}
+ /**
+ * Cells in a bulkloaded file don't have a sequenceId since they don't go
through memstore. When a
+ * bulkload file is committed, the current memstore ts is stamped onto the
file name as the
Review Comment:
Yikes! Seems like we need a seqId field in the file header instead of
relying on the file name...
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byte[]
tableName, byte[] suffix)
* package-private for internal usage for jobs like WALPlayer which need to
use features of
* ExtendedCell.
*/
- static final String EXTENDED_CELL_SERIALIZATION_ENABLED_KEY =
+ public static final String EXTENDED_CELL_SERIALIZATION_ENABLED_KEY =
Review Comment:
This field is becoming part of the public API. It's worth updating the
comment about its usage.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -415,17 +410,15 @@ private void open() throws IOException {
if (isBulkLoadResult()) {
// generate the sequenceId from the fileName
// fileName is of the form <randomName>_SeqId_<id-when-loaded>_
Review Comment:
delete this stale comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
