bbeaudreault commented on code in PR #5775:
URL: https://github.com/apache/hbase/pull/5775#discussion_r1539191315
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byte[]
tableName, byte[] suffix)
* package-private for internal usage for jobs like WALPlayer which need to
use features of
* ExtendedCell.
*/
- static final String EXTENDED_CELL_SERIALIZATION_ENABLED_KEY =
+ public static final String EXTENDED_CELL_SERIALIZATION_ENABLED_KEY =
Review Comment:
@ndimiduk I decided to annotate that as IA.Private. I know we generally
prefer not to do that for fields/methods, but for better or worse there's
already a strong convention of doing it in this class (11 methods annotated
IA.Private). It's probably worth a larger refactor/cleanup of HFileOutputFormat2
Let me know if you strongly disagree with this approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
