jhungund commented on code in PR #5829:
URL: https://github.com/apache/hbase/pull/5829#discussion_r1572253085
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -999,6 +1019,12 @@ void freeSpace(final String why) {
}
}
+ // Check if the cold file eviction is sufficient to create enough space.
Review Comment:
@wchevreuil, right now in the code, I am evicting all the cold files and
then checking if we have more bytes to free.
Would it make sense to do it like this or do we want to evict only upto
bytesToFreeWithExtra and exit leaving behind some of the cold blocks?
Which one would be preferable? The later option seems user friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
