wchevreuil commented on code in PR #5829:
URL: https://github.com/apache/hbase/pull/5829#discussion_r1572259557
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -999,6 +1019,12 @@ void freeSpace(final String why) {
}
}
+ // Check if the cold file eviction is sufficient to create enough space.
Review Comment:
I don't know, just wanted to make sure we considered the two options. If we
delete all cold files even if that meant we will free more than the originally
wanted free bytes, we might delay further mass evictions, at the cost of having
more misses if these cold blocks are still accessed. I leave the final decision
to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
