anmolnar commented on code in PR #5785:
URL: https://github.com/apache/hbase/pull/5785#discussion_r1575062555


##########
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java:
##########
@@ -110,6 +112,23 @@ public static RecoverableZooKeeper connect(Configuration 
conf, String ensemble,
    */
   public static RecoverableZooKeeper connect(Configuration conf, String 
ensemble, Watcher watcher,
     final String identifier) throws IOException {
+    return connect(conf, ensemble, watcher, identifier, null);

Review Comment:
   `ZKClientConfig` param is marked as Nullable in ZK code, so I think it's 
fine to pass null here. However you can also use the method overload _without_ 
client config parameter if you don't want to customize it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to