Apache9 commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2073849380
> @Apache9 If I understand correctly #5835 have solved [HBASE-28464](https://issues.apache.org/jira/browse/HBASE-28464) and made this PR obsolete. Why should we rebase the PR here? Am I missing something? You are right... I was thinking that we have some special code in HBaseReplicationEndpoint for creating the ZKWatcher so we also need to modify it in this PR but actually, the creation of ZKClientConfig is inside ZKWatcher itself, so we do not need to touch HBaseReplicationEndpoint... So I think this issue can be resolved as implemented by HBASE-28529. Thanks for pointing this out. And feel free to reopen or open new issues and ping me again if HBASE-28529 can not solve all your problems. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
