ndimiduk commented on code in PR #5850:
URL: https://github.com/apache/hbase/pull/5850#discussion_r1596482388
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistryURIFactory.java:
##########
@@ -30,9 +34,34 @@
* Connection registry creator implementation for creating {@link
ZKConnectionRegistry}.
*/
@InterfaceAudience.Private
-public class ZKConnectionRegistryCreator implements
ConnectionRegistryURIFactory {
+public class ZKConnectionRegistryURIFactory implements
ConnectionRegistryURIFactory {
- private static final Logger LOG =
LoggerFactory.getLogger(ZKConnectionRegistryCreator.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(ZKConnectionRegistryURIFactory.class);
+
+ public static final String SESSION_TIMEOUT = "session.timeout.ms";
Review Comment:
While I appreciate the convenience of these shortened configuration strings,
I think that we should also accept the full configuration key as it is read
from hbase-site.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
