Apache9 commented on code in PR #5850:
URL: https://github.com/apache/hbase/pull/5850#discussion_r1597646001
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistryURIFactory.java:
##########
@@ -30,9 +34,34 @@
* Connection registry creator implementation for creating {@link
ZKConnectionRegistry}.
*/
@InterfaceAudience.Private
-public class ZKConnectionRegistryCreator implements
ConnectionRegistryURIFactory {
+public class ZKConnectionRegistryURIFactory implements
ConnectionRegistryURIFactory {
- private static final Logger LOG =
LoggerFactory.getLogger(ZKConnectionRegistryCreator.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(ZKConnectionRegistryURIFactory.class);
+
+ public static final String SESSION_TIMEOUT = "session.timeout.ms";
Review Comment:
This is just another choice comparing to #5853 . Since you and @bbeaudreault
both think allowing users to override all configuration through URI queries is
acceptable, I think we could go #5853 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
