wchevreuil commented on code in PR #5906:
URL: https://github.com/apache/hbase/pull/5906#discussion_r1636728468
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java:
##########
@@ -45,7 +45,7 @@ public HFilePreadReader(ReaderContext context, HFileInfo
fileInfo, CacheConfig c
});
// Prefetch file blocks upon open if requested
- if (cacheConf.shouldPrefetchOnOpen() && cacheIfCompactionsOff() &&
shouldCache.booleanValue()) {
+ if (cacheConf.shouldPrefetchOnOpen() && shouldCache.booleanValue()) {
Review Comment:
Same reason as explained here:
https://github.com/apache/hbase/pull/5906/files#r1606971440. We want the
prefetch to run even for refs or links, the cache implementation should decide
what to do with refs/links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
