wchevreuil commented on code in PR #5906:
URL: https://github.com/apache/hbase/pull/5906#discussion_r1637094367
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java:
##########
@@ -244,6 +248,45 @@ public static int getMaxCachedBlocksByFile(Configuration
conf) {
return conf == null ? DEFAULT_MAX :
conf.getInt("hbase.ui.blockcache.by.file.max", DEFAULT_MAX);
}
+ /**
+ * Similarly to HFileBlock.Writer.getBlockForCaching(), creates a HFileBlock
instance without
Review Comment:
So the most I could reuse here is the new HFIleContext part. The block
builder portion is hard to reuse because in HFileBlock.Writer the parameters
are calculated on the go, so any sort of reuse would require an awful lot of
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
