ndimiduk commented on code in PR #6076:
URL: https://github.com/apache/hbase/pull/6076#discussion_r1682662428
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutator.java:
##########
@@ -93,4 +94,11 @@ default CompletableFuture<Void> mutate(Mutation mutation) {
default long getPeriodicalFlushTimeout(TimeUnit unit) {
throw new UnsupportedOperationException("Not implemented");
}
+
+ /**
+ * Returns the rpc request attributes.
+ */
+ default Map<String, byte[]> getRequestAttributes() {
+ throw new UnsupportedOperationException("Not implemented");
Review Comment:
The `BufferedMutatorParams` object seems transient to me, while the
`[Async]BufferedMutator` is the "durable" class that is used by the client. As
such, I think it makes sense to keep the interface on `[Async]BufferedMutator`.
It _seems_ like all the `Table` and `BufferedMutator` variants will return
an empty collection when there are no (connection|request) attributes present,
so it seems fine to me to have the interfaces provide a default implementation
that returns an immutable empty collection. But I don't feel strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
