eab148 commented on code in PR #6076:
URL: https://github.com/apache/hbase/pull/6076#discussion_r1681560430
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorBuilder.java:
##########
@@ -38,6 +39,16 @@ public interface AsyncBufferedMutatorBuilder {
*/
AsyncBufferedMutatorBuilder setRpcTimeout(long timeout, TimeUnit unit);
+ /**
+ * Set a rpc request attribute.
+ */
+ AsyncBufferedMutatorBuilder setRequestAttribute(String key, byte[] value);
Review Comment:
> Ah, or maybe you're hamstrung by the apis that TableBuilder exposes?
Yeah, currently the `AsyncBufferedMutatorBuilderImpl` wraps an
`AsyncTableBuilder`
([code](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorBuilderImpl.java#L34)).
> Maybe we should look at expanding the scope of these methods in a separate
JIRA.
I think this is a good idea. When I drafted this PR, I had a difficult time
understanding what semantics we support and why.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorBuilder.java:
##########
@@ -38,6 +39,16 @@ public interface AsyncBufferedMutatorBuilder {
*/
AsyncBufferedMutatorBuilder setRpcTimeout(long timeout, TimeUnit unit);
+ /**
+ * Set a rpc request attribute.
+ */
+ AsyncBufferedMutatorBuilder setRequestAttribute(String key, byte[] value);
Review Comment:
> Ah, or maybe you're hamstrung by the apis that TableBuilder exposes?
Yeah, currently the `AsyncBufferedMutatorBuilderImpl` wraps an
`AsyncTableBuilder`
([code](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorBuilderImpl.java#L34)).
> Maybe we should look at expanding the scope of these methods in a separate
JIRA.
I think this is a good idea. When I drafted this PR, I had a difficult time
understanding what semantics we support and why we chose them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
