charlesconnell commented on code in PR #6168:
URL: https://github.com/apache/hbase/pull/6168#discussion_r1741269725
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableImpl.java:
##########
@@ -311,7 +321,11 @@ public void onRegionError(RegionInfo region, Throwable
error) {
@Override
public void onComplete() {
- pool.execute(context.wrap(callback::onComplete));
+ pool.execute(context.wrap(() -> {
+ // Guarantee that onComplete() is called after all
onRegionComplete()'s are called
+ regionCompletesInProgress.arriveAndAwaitAdvance();
Review Comment:
Good point that onRegionError should be included in the barrier. I'm
guessing you meant to say "so I think that this _cannot_ be solved with a
phaser," but I disagree. The phaser can be used in onRegionError just the same
as onRegionComplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
