ndimiduk commented on code in PR #6168:
URL: https://github.com/apache/hbase/pull/6168#discussion_r1741582018
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableImpl.java:
##########
@@ -311,7 +321,11 @@ public void onRegionError(RegionInfo region, Throwable
error) {
@Override
public void onComplete() {
- pool.execute(context.wrap(callback::onComplete));
+ pool.execute(context.wrap(() -> {
+ // Guarantee that onComplete() is called after all
onRegionComplete()'s are called
+ regionCompletesInProgress.arriveAndAwaitAdvance();
Review Comment:
Oh I see. Phaser is more powerful than I initially understood -- very cool!
Yes, this looks better to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
