Apache9 commented on PR #6179: URL: https://github.com/apache/hbase/pull/6179#issuecomment-2329202080
OK, in the old time, if there are unflushed entries, we will throw IOException out and abort the region server... When optimizing the close logic, we finally changed the code to the current situation. I think the intention here is that, if there are still unflushed entries after closing writer, there should be an exception thrown out which aborts the region server. But looking at the implementation of getUnflushedEntriesCount, since we do not block others threads from adding new entries to the ring buffer, the getUnflushedEntriesCount could be greater than 0 even if there are no errors, so I think we need to take a look at the whole logic again, the isUnflushedEntries is not what we want now I'm afraid... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
