Apache9 commented on code in PR #6179:
URL: https://github.com/apache/hbase/pull/6179#discussion_r1759746515
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java:
##########
@@ -390,10 +390,10 @@ protected void doReplaceWriter(Path oldPath, Path
newPath, Writer nextWriter) th
try {
closeWriter(this.writer, oldPath, true);
} finally {
+ // closing this as there is no other chance we can set close to
true
+ // during clean up we check for unflushed entries
+ markClosedAndClean(oldPath);
Review Comment:
Do you plan to fix the background close issue or you just want to add some
logs in this issue and file new issues for addressing the background close
issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
