NihalJain commented on PR #6249:
URL: https://github.com/apache/hbase/pull/6249#issuecomment-2353798881
Change Summary
- Added a new module called hbase-diagnostics (as suggested by Istvan)
- Question: Any better names?
- Created a copy just to bring out the all the usages of the class to help
decide where we move this in final patch:
- RandomDistribution
- KeyProviderForTesting
- LoadTestKVGenerator
- Added a new util DiagnosticToolsCommonUtils.java and moved method required
to loginAndReturnUGI from HBaseKerberosUtils.java
- Added a new util LoadTestUtil and moved all load test related code from
HFileTestUtil and HBaseTestingUtil to here
- Question: Should we merge this to DiagnosticToolsCommonUtils?
- Copied generateData() from PerformanceEvaluation.java in
TestHFileOutputFormat2.java to break cyclic dependency
- Added @InterfaceAudience.Private to all classes moved from test code to
main
- Replaced UTIL.getConfiguration() with HBaseConfiguration.create() in
LoadBalancerPerformanceEvaluation.java
TODO
- Need to handle testHBASE14489() in hbase-server tests which depends on
FilterAllFilter(), should we move this class to main of hbase-server or
hbase-common?
- TODO: How to deal with copied classes which have cyclic dependencies,
should copy to main of hbase-server or hbase-common?
- Some manual Testing
- Anything else which we need to handle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
