Apache-HBase commented on PR #6249: URL: https://github.com/apache/hbase/pull/6249#issuecomment-2354054206
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 38s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. | |||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | | master passed | | +1 :green_heart: | compile | 12m 38s | | master passed | | +1 :green_heart: | checkstyle | 1m 41s | | master passed | | +1 :green_heart: | spotbugs | 18m 13s | | master passed | | +1 :green_heart: | spotless | 0m 52s | | branch has no errors when running spotless:check. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 32s | | the patch passed | | +1 :green_heart: | compile | 8m 15s | | the patch passed | | -0 :warning: | javac | 8m 15s | [/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6249/2/artifact/yetus-general-check/output/results-compile-javac-root.txt) | root generated 61 new + 1207 unchanged - 4 fixed = 1268 total (was 1211) | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 1m 12s | [/results-checkstyle-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6249/2/artifact/yetus-general-check/output/results-checkstyle-root.txt) | root: The patch generated 43 new + 58 unchanged - 36 fixed = 101 total (was 94) | | +1 :green_heart: | xmllint | 0m 2s | | No new issues. | | -1 :x: | spotbugs | 7m 44s | [/new-spotbugs-root.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6249/2/artifact/yetus-general-check/output/new-spotbugs-root.html) | root generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0) | | +1 :green_heart: | hadoopcheck | 11m 47s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | | +1 :green_heart: | spotless | 0m 45s | | patch has no errors when running spotless:check. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 33s | | The patch does not generate ASF License warnings. | | | | 90m 9s | | | | Reason | Tests | |-------:|:------| | SpotBugs | module:root | | | Integral division result cast to double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:double or float in org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions) At PerformanceEvaluation.java:[line 3154] | | | org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines compareTo(PerformanceEvaluation$RunResult) and uses Object.equals() At PerformanceEvaluation.java:Object.equals() At PerformanceEvaluation.java:[line 250] | | | Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) At LoadTestKVGenerator.java:[line 111] | | | org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER isn't final but should be At LoadTestTool.java:be At LoadTestTool.java:[line 163] | | | org.apache.hadoop.hbase.util.LoadTestUtil.DEFAULT_COLUMN_FAMILY should be both final and package protected At LoadTestUtil.java:and package protected At LoadTestUtil.java:[line 48] | | | org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result, boolean, boolean) concatenates strings using + in a loop At MultiThreadedAction.java:using + in a loop At MultiThreadedAction.java:[line 414] | | | Integral division result cast to double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:double or float in org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run() At MultiThreadedAction.java:[line 203] | | | org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long) concatenates strings using + in a loop At MultiThreadedReader.java:in a loop At MultiThreadedReader.java:[line 318] | | | Dead store to rowKey in org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get, boolean, long) At MultiThreadedReaderWithACL.java:[line 91] | | | Inconsistent synchronization of org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time Unsynchronized access at MultiThreadedUpdater.java:75% of time Unsynchronized access at MultiThreadedUpdater.java:[line 80] | | | Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6249/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/6249 | | Optional Tests | dupname asflicense javac codespell detsecrets xmllint spotless spotbugs checkstyle compile hadoopcheck hbaseanti | | uname | Linux 80ed0d4779d0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 469be3d3d2e106f41c28d10938b296e9fb673ec6 | | Default Java | Eclipse Adoptium-17.0.11+9 | | Max. process+thread count | 190 (vs. ulimit of 30000) | | modules | C: hbase-common hbase-client hbase-balancer hbase-asyncfs hbase-server hbase-mapreduce hbase-diagnostics hbase-compression/hbase-compression-zstd . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6249/2/console | | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 | | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
