PDavid commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1818954197
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java:
##########
@@ -169,7 +169,7 @@ private void mpOneTest(Filter filterMPONE) throws Exception
{
assertTrue(filterMPONE.filterRowKey(KeyValueUtil.createFirstOnRow(rowkey)));
kv = new KeyValue(rowkey, rowkey, Bytes.toBytes(0), Bytes.toBytes(0));
assertFalse(Filter.ReturnCode.INCLUDE == filterMPONE.filterCell(kv));
- assertFalse(filterMPONE.filterRow());
+ assertTrue(filterMPONE.filterRow());
Review Comment:
Thanks for the question. :+1:
Yeah, to be completely honest I was not fully understanding how this
`filterRow()` should work and just adjusted this test.
As discussed, `PrefixFilter.filterRow()` should be adjusted instead.
I'll revert this test change and adjust `PrefixFilter.filterRow()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
