PDavid commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1818979079
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -69,13 +74,19 @@ public boolean filterRowKey(Cell firstRowCell) {
if ((!isReversed() && cmp > 0) || (isReversed() && cmp < 0)) {
passedPrefix = true;
}
- filterRow = (cmp != 0);
+ filterRow = (!isReversed() && cmp > 0) || (isReversed() && cmp < 0);
+ provideHint = (!isReversed() && cmp < 0) || (isReversed() && cmp > 0);
Review Comment:
Thanks. I think this is similar to what I mentioned here:
https://github.com/apache/hbase/pull/6361#discussion_r1818975275
If I understand it correctly, the filter only provide a hint once, the next
cell will either already be a match or there will be no cells. But maybe I'm
missing something... :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
