PDavid commented on PR #6490: URL: https://github.com/apache/hbase/pull/6490#issuecomment-2516485584
> Hi @PDavid I checked out code and had a look at Master and RS pages. All pages seem to work perfectly fine in these 2 web UIs, that's great work, thanks :) > > ## Have a few suggestions though > 1. **Styling/Colors** > > Can we make the UI coloring look similar to what we had before? For example now the blue colors are very dark over the dull blue we had earlier, which was not very heavy on eyes. > > You could try to override default bootstrap.css in hbase.css? For example replacing reference to #0d6efd with #337ab7 results in following. > >  > > Would need to compare with old HBase UI where ever we have noticeable discrepancy in colors. Although it should be fine if new colors looks better than before. > > 2. **Active Tab Indicator** > > Also the active navbar highlighting is either broken or not as before. Can this be fixed? This is how it used to render earlier > >  > > BTW I have not looked at code changes line by line as of yet, have just tried the change locally. Will review code and other web pages soon. Overall things look good to me visually. Hi @NihalJain, Many thanks for the feedback! :+1: To be completely honest I was not sure how important it is to preserve the look and styling of the current HBase UI. Of course I'll' look into it and restore these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
