NihalJain commented on PR #6490:
URL: https://github.com/apache/hbase/pull/6490#issuecomment-2516426378

   Hi @PDavid I checked out code and had a look at Master and RS pages. All 
pages seem to work perfectly fine in these 2 web UIs, that's great work, thanks 
:)
   
   Have a few suggestions though
   ---
   1) **Styling/Colors**
   
   Can we make the UI coloring look similar to what we had before? For example 
now the blue colors are very dark over the dull blue we had earlier, which was 
no very heavy on eyes. 
   
   You could try to override default bootstrap.css in hbase.css? For example 
replacing reference to #0d6efd with #337ab7 results in following. 
   
   With above change, page looks a lot like before wrt blue colors:
   ![Screenshot 2024-12-04 at 1 03 51 
PM](https://github.com/user-attachments/assets/8405b684-b0d4-4c94-8421-33133e421d1d)
   
   Would need to compare with old HBase UI where ever we have discrepancy in 
colors.
   
   ---
   2) **Active Tab Indicator**
   
   Also the active navbar highlighting is either broken or not as before. Can 
this be fixed? This is it rendered earlier
   
   ![Screenshot 2024-12-04 at 1 07 39 
PM](https://github.com/user-attachments/assets/43959071-541e-4cb0-b876-bb933308fb04)
   ---
   
   Have not looked at code changes line by line as of yet, have just tried the 
change locally. Will review code and other web pages soon.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to