[jira] [Commented] (HBASE-28767) Simplify backup bulk-loading code

[Nick Dimiduk (Jira)]

    [ 
https://issues.apache.org/jira/browse/HBASE-28767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905500#comment-17905500
 ] 

Nick Dimiduk commented on HBASE-28767:
--------------------------------------

In backporting this patch, I noticed that {{TestIncrementalBackupWithBulkLoad}} 
isn't present on branch-2. I did a quick check and this is the only test that 
is missing.

{noformat}
 % diff -u <(git ls-tree apache/master --name-only -r 
hbase-backup/src/test/java) <(git ls-tree apache/branch-2 --name-only -r 
hbase-backup/src/test/java)
--- /dev/fd/11  2024-12-13 15:09:26
+++ /dev/fd/12  2024-12-13 15:09:26
@@ -28,7 +28,6 @@
 
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupDeleteTable.java
 
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithBulkLoad.java
 
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java
-hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithBulkLoad.java
 
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithDataLoss.java
 
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithFailures.java
 hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRemoteBackup.java
{noformat}

I'm going to try restoring it to branch-2 and branch-2.6.

> Simplify backup bulk-loading code
> ---------------------------------
>
>                 Key: HBASE-28767
>                 URL: https://issues.apache.org/jira/browse/HBASE-28767
>             Project: HBase
>          Issue Type: Task
>          Components: backup&amp;restore
>    Affects Versions: 2.6.0, 3.0.0-beta-1
>            Reporter: Dieter De Paepe
>            Assignee: Dieter De Paepe
>            Priority: Minor
>              Labels: pull-request-available
>
> While working on HBASE-28706, I came across a lot of overly complex/duplicate 
> code related to how bulk uploads are tracked for backups.
> This ticket is to simplify some of it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)