vinayakphegde commented on code in PR #6518: URL: https://github.com/apache/hbase/pull/6518#discussion_r1891243636
########## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/replication/ContinuousBackupManager.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.backup.replication; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.FileUtil; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.wal.WAL; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Manages the continuous backup process for HBase WAL entries and bulk load files. + * <p> + * This class is responsible for initializing backup components, processing WAL entries, staging + * them for backup, and committing the backup to the configured storage. It uses + * {@link BackupFileSystemManager} for handling file system operations and + * {@link ContinuousBackupStagingManager} for managing staging. + * </p> + */ [email protected] +public class ContinuousBackupManager { + private static final Logger LOG = LoggerFactory.getLogger(ContinuousBackupManager.class); + public static final String CONF_BACKUP_ROOT_DIR = "hbase.backup.root.dir"; Review Comment: No, this is for the wal backup location. We'll have the WAL backup location, which is passed to the ReplicationEndpoint via the Configuration. Essentially, this serves as the argument for the ReplicationEndpoint to determine where to back up the data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
