vinayakphegde commented on code in PR #6518: URL: https://github.com/apache/hbase/pull/6518#discussion_r1893507630
########## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/replication/ContinuousBackupStagedHFileCleaner.java: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.backup.replication; + +import java.io.IOException; +import java.util.Collections; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.Abortable; +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.hadoop.hbase.client.Connection; +import org.apache.hadoop.hbase.client.ConnectionFactory; +import org.apache.hadoop.hbase.master.cleaner.BaseHFileCleanerDelegate; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hbase.thirdparty.com.google.common.collect.Iterables; + +/** + * A custom HFile cleaner delegate for continuous backup scenarios in HBase. This cleaner prevents + * the deletion of HFiles that are staged for bulk loading as part of the continuous backup process. + * It interacts with the HBase `StagedBulkloadFileRegistry` to determine which files should be + * retained. + * <p> + * Implements the {@link BaseHFileCleanerDelegate} for integrating with the HBase cleaner framework + * and the {@link Abortable} interface to handle error scenarios gracefully. + * </p> + */ [email protected](HBaseInterfaceAudience.CONFIG) +public class ContinuousBackupStagedHFileCleaner extends BaseHFileCleanerDelegate + implements Abortable { + private static final Logger LOG = + LoggerFactory.getLogger(ContinuousBackupStagedHFileCleaner.class); + + private boolean stopped = false; + private boolean aborted; + private Configuration conf; + private Connection connection; + + @Override + public void setConf(Configuration config) { + this.conf = config; + this.connection = null; + try { + // Establishing HBase connection + this.connection = ConnectionFactory.createConnection(conf); + LOG.info("HBase connection established successfully."); + } catch (IOException ioe) { + LOG.error("Couldn't establish connection to HBase", ioe); + } + } + + @Override + public Iterable<FileStatus> getDeletableFiles(Iterable<FileStatus> files) { + if (conf == null) { + LOG.warn("Configuration is not set. Returning original list of files."); + return files; + } + + if (connection == null) { + try { + connection = ConnectionFactory.createConnection(conf); + LOG.info("HBase connection re-established in getDeletableFiles."); + } catch (IOException e) { + LOG.error("Failed to re-establish HBase connection. Returning no deletable files.", e); + return Collections.emptyList(); + } + } + + try { + // Fetch staged files from HBase + Set<String> stagedFiles = StagedBulkloadFileRegistry.listAllBulkloadFiles(connection); + LOG.debug("Fetched {} staged files from HBase.", stagedFiles.size()); + + // Extract file names from staged files + Set<String> stagedFileNames = + stagedFiles.stream().map(path -> new Path(path).getName()).collect(Collectors.toSet()); + + // Filter files by checking their file names against staged file names + return Iterables.filter(files, file -> !stagedFileNames.contains(file.getPath().getName())); + } catch (IOException e) { + LOG.error("Failed to fetch staged bulkload files from HBase. Returning no deletable files.", + e); + return Collections.emptyList(); + } + } + + @Override + public boolean isFileDeletable(FileStatus fStat) { + // The actual deletion decision is made in getDeletableFiles, so returning true Review Comment: This approach would be slightly faster, right? In `getDeletableFiles`, we could run the query once and process all the results together, instead of executing multiple queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
