NihalJain commented on PR #6551: URL: https://github.com/apache/hbase/pull/6551#issuecomment-2556344847
Reviewing commit by commit: 1. [HBASE-24624](https://issues.apache.org/jira/browse/HBASE-24624) Optimize table.jsp code: This change is huge wrt to original PR, @PDavid could you summarise what all we changed here? Is this an whitespace issue? Mind fixing it? 2. [HBASE-25402](https://issues.apache.org/jira/browse/HBASE-25402) Sorting order by start key or end key is not considering empty start key/end key: LGTM 3. [HBASE-28778](https://issues.apache.org/jira/browse/HBASE-28778) NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing : Apparently this was already backported with original ticket, we just missed a few files back then.! LGTM 4. [HBASE-20452](https://issues.apache.org/jira/browse/HBASE-20452) Master UI: Table merge button should validate required fields before submit: LGTM Also could you please summarise how the changes have been tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
