NihalJain commented on PR #6542: URL: https://github.com/apache/hbase/pull/6542#issuecomment-2560763417
We may need to drop [HBASE-27406](https://issues.apache.org/jira/browse/HBASE-27406) Make /prometheus endpoint accessible from HBase UI (https://github.com/apache/hbase/pull/4833) as the feature is not even supported by backend. Trying to open /prometheus give 404 with this change. <img width="716" alt="Screenshot 2024-12-24 at 12 31 09 PM" src="https://github.com/user-attachments/assets/0ff03913-43dd-4502-a303-90532e5fdac7" /> Otherwise tried the change, they work fine for me: - Master: LGTM, except navbar all look good. Again navbar should not be issue as bootstrap bump will fix it eventually <img width="1492" alt="Screenshot 2024-12-24 at 12 46 46 PM" src="https://github.com/user-attachments/assets/6caa5083-bd50-405f-b38d-e1b887e99904" /> --- - Rest UI: LGTM <img width="1491" alt="Screenshot 2024-12-24 at 12 46 29 PM" src="https://github.com/user-attachments/assets/88404616-4636-4c48-ac4c-8846d6587502" /> --- - Thrift UI: LGTM <img width="1481" alt="Screenshot 2024-12-24 at 12 46 35 PM" src="https://github.com/user-attachments/assets/5bee2dc1-be93-4771-b474-ce4ac0f79c65" /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
