Re: [PR] HBASE-29028 Backport missing UI patches to branch-2.5 [hbase]

[via GitHub]

PDavid commented on PR #6542:
URL: https://github.com/apache/hbase/pull/6542#issuecomment-2572846878

   Hi @NihalJain,
   
   Many thanks for testing the changes. :+1: 
   
   > We may need to drop 
[HBASE-27406](https://issues.apache.org/jira/browse/HBASE-27406) Make 
/prometheus endpoint accessible from HBase UI (#4833) as the feature is not 
even supported by backend. Trying to open /prometheus give 404 with this change.
   > 
   > <img alt="Screenshot 2024-12-24 at 12 31 09 PM" width="716" 
src="https://private-user-images.githubusercontent.com/3429351/398350281-4428f580-1657-4c47-8ae3-b880cc5796ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYxNDUxNTcsIm5iZiI6MTczNjE0NDg1NywicGF0aCI6Ii8zNDI5MzUxLzM5ODM1MDI4MS00NDI4ZjU4MC0xNjU3LTRjNDctOGFlMy1iODgwY2M1Nzk2YWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDEwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAxMDZUMDYyNzM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDBhZTQ0MmVhZTAyNGFlNTE0ODU2MGNmZGE0MWQzNjRjNTczZjYxNjkyYzcwMThhMWNkNzk1YjMyMGQwODRjNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.VHCr9P3Vpx4GdF0TvuUBVX0OU0qXYU-7ZM0JYmbKWoU";>
   
   Very good catch, thanks. I was not aware and somehow did not found this. 
:man_facepalming:  I'll have a look and fix this.
   
   Would it work if we keep the "Metrics" dropdown but remove the Prometheus 
links? So we would only have the "JMX" and "JMX with description" links there.
   
   What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org