[
https://issues.apache.org/jira/browse/HBASE-29024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914755#comment-17914755
]
Andrew Kyle Purtell edited comment on HBASE-29024 at 1/20/25 6:12 PM:
----------------------------------------------------------------------
[~stoty]
Edited.
I have no objection to removing test only dependencies from binary convenience
artifacts but have worked with the hbase-external-blockcache component fairly
recently and might consider it for a future use case, as mentioned on the
thread on dev@. So if we are considering removing spymemcached from binary
assemblies, +1 to that, there's no need for test-only dependencies like that at
runtime in production. But if considering removal of the dependency at compile
scope too, requiring the removal of the component's unit tests, or the
component itself, then I would vote -1 to that without additional discussion.
Maybe we can attach maintenence requirements to keeping it, would not be
opposed to such a discussion.
/cc [~zhangduo]
was (Author: apurtell):
[~stoty] What is the issue? Is there a CVE or reported security problem with
spymemcached? It is only used in the tests for the hbase-external-blockcache
module.
I have tested the hbase-external-blockcache module, after fixing it in
HBASE-27796 it does plausibly work. It provides an option to externalize the
block cache. We were looking at it once at my work and still might consider it
in the future. Combined with, ok, other significant changes that would also
need to land first, you can imagine for each table or namespace a separate
external blockcache. This allows an operator to allocate cache resources for a
customer's table or namespace and then the cache for the customer's table or
namespace is dedicated to that customer and also the costs of operating it are
easily accounted to the customer for charge-back or show-back. Without
hbase-external-blockcache, all options like this are foreclosed.
> Remove spymemcached from assembly
> ---------------------------------
>
> Key: HBASE-29024
> URL: https://issues.apache.org/jira/browse/HBASE-29024
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, build
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> As discussed on the mailing list, we should remove the spymemcached client
> jar from the assembly.
> At the same time, we should add instructions in the reference guide on how to
> add it manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
