hgromer commented on PR #6623: URL: https://github.com/apache/hbase/pull/6623#issuecomment-2651341232
> So high-level question: why is this a new `QueryMetrics` instead of expanding use of the existing `ScanMetrics` to all query types? That class even includes the comment, > > ``` > * Some of these metrics are general for any client operation such as put However, there is no need > * for this. So they are defined under scan operation for now. > ``` My main reasoning was that some metrics exclusively make sense for scans. I thought it'd be confusing to include those metrics in Result objects that were fetched via Get or MultiGet. Another reason for keeping them separate was to make it easier to expand one and not the other in the future. I worry about having one large object will make things harder to extend in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
