ndimiduk commented on code in PR #6623:
URL: https://github.com/apache/hbase/pull/6623#discussion_r1971446697
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -2594,7 +2596,13 @@ private Result get(Get get, HRegion region,
RegionScannersCloseCallBack closeCal
}
region.metricsUpdateForGet();
- return Result.create(results, get.isCheckExistenceOnly() ?
!results.isEmpty() : null, stale);
+ Result r =
+ Result.create(results, get.isCheckExistenceOnly() ? !results.isEmpty() :
null, stale);
+ if (get.isQueryMetricsEnabled()) {
+ long blockBytesScanned = context.getBlockBytesScanned() -
blockBytesScannedBefore;
Review Comment:
it would be cleaner if we pushed the blockBytesScanner into the
`RegionScanner`. It could provide an accessor that is updated with each call to
`next()`. This maintenance of a subtractive counter seems odd.
That's probably outside of scope of this PR.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/QueryMetrics.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+
[email protected]
+public class QueryMetrics {
Review Comment:
Also decorate this class with `IS.Unstable` or `Evolving`. Whichever you
choose, also place the same annotation on the public accessor methods on all
the `IA.Public` classes. Let's give ourselves a change to explore this feature
and make changes faster than once every 5 years.
##########
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestOnlineLogRecord.java:
##########
@@ -44,21 +44,21 @@ public void itSerializesScan() {
Scan scan = new Scan();
scan.withStartRow(Bytes.toBytes(123));
scan.withStopRow(Bytes.toBytes(456));
- String expectedOutput =
- "{\n" + " \"startTime\": 1,\n" + " \"processingTime\": 2,\n" + "
\"queueTime\": 3,\n"
Review Comment:
This assertion is dumb any could be replaced by literally any modern library
for asserts on JSON blobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
