NihalJain commented on code in PR #6668:
URL: https://github.com/apache/hbase/pull/6668#discussion_r1970511224
##########
pom.xml:
##########
@@ -2910,6 +2987,55 @@
</target>
</configuration>
</execution>
+ <!-- Copy static CSS and JS files for the website. -->
+ <execution>
+ <id>copy-css-js-to-site</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+ <target>
+ <copy flatten="true"
todir="${project.build.directory}/site/css">
Review Comment:
Since we are unpacking with an includes in "maven-dependency-plugin", can't
we simply copy everything under say
"${project.build.directory}/META-INF/resources/webjars/*/*/styles" and so on to
"${project.build.directory}/site/css"? We could do same for js, css and fonts.
Or are we doing anything extra here which won't work unless we specify explicit
includes for each artifact?
##########
pom.xml:
##########
@@ -2910,6 +2987,55 @@
</target>
</configuration>
</execution>
+ <!-- Copy static CSS and JS files for the website. -->
+ <execution>
+ <id>copy-css-js-to-site</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+ <target>
+ <copy flatten="true"
todir="${project.build.directory}/site/css">
Review Comment:
Since we are unpacking with an includes, can't we simply copy everything
under say "${project.build.directory}/META-INF/resources/webjars/*/*/styles"
and so on to "${project.build.directory}/site/css"? We could do same for js,
css and fonts. Or are we doing anything extra here which won't work unless we
specify explicit includes for each artifact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
