PDavid commented on code in PR #6668:
URL: https://github.com/apache/hbase/pull/6668#discussion_r1971093220
##########
pom.xml:
##########
@@ -2749,6 +2749,81 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack</id>
+ <goals>
+ <goal>unpack</goal>
+ </goals>
+ <phase>pre-site</phase>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.webjars</groupId>
+ <artifactId>bootstrap</artifactId>
+ <version>2.3.2</version>
Review Comment:
> I am assuming we are using old version here to avoid bumping version (and
hence introducing a new change) but retain site as is i.e. just bundling static
files with versions as it would be today via cdn.
Yes, exactly.
>
> Do we plan to bump these? May be create follow ups?
I completely agree, it would be great to bump the Bootstrap version but it
is not so easy as the currently used site Maven skin only works with the old
Bootstrap 2.x and it would not render correctly with newer Bootstrap version.
Actually the Apache Phoenix project uses the [Reflow Maven
skin](https://devacfr.github.io/reflow-maven-skin/) and that supports newer
Bootstrap 4.x (still not ideal because 5.x is the latest major version). This
skin also supports [multiple
themes](https://devacfr.github.io/reflow-maven-skin/doc/reflow-documentation.html#doc-themes-index)
and has many customization possibilities.
I'll create followup ticket for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
